Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_services submodule #133

Merged
merged 10 commits into from
Jan 31, 2019

Conversation

sosimon
Copy link

@sosimon sosimon commented Jan 24, 2019

Adding a submodule to activate project APIs. Project Factory already does this, but having this submodule means it can be reused even for projects that were not created with Project Factory.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a good first pass.

modules/project_services/variables.tf Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/outputs.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny nits.

examples/project_services/README.md Outdated Show resolved Hide resolved
examples/project_services/main.tf Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/README.md Show resolved Hide resolved
@sosimon
Copy link
Author

sosimon commented Jan 29, 2019

@morgante How do the changes look?

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits.

modules/project_services/README.md Outdated Show resolved Hide resolved
modules/project_services/README.md Outdated Show resolved Hide resolved
morgante
morgante previously approved these changes Jan 30, 2019
@morgante
Copy link
Contributor

@sosimon Please resolve linting errors:

./modules/project_services/README.md:1. Service account used to run Terraform has permissions to manage project APIs: 

@sosimon
Copy link
Author

sosimon commented Jan 30, 2019

@morgante Linting error fixed

@morgante morgante merged commit 560589c into terraform-google-modules:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants