Skip to content

Commit

Permalink
Drop unused permissions from preconditions script
Browse files Browse the repository at this point in the history
  • Loading branch information
adrienthebo committed Feb 21, 2019
1 parent edd458f commit 3950915
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ class OrgPermissions:
ALL_PERMISSIONS = [
# Typically granted with `roles/resourcemanager.organizationViewer`
"resourcemanager.organizations.get",

# Typically granted with `roles/iam.serviceAccountAdmin`
"iam.serviceAccounts.setIamPolicy",
]

# Permissions required when the service account is attaching a new project
Expand Down Expand Up @@ -146,9 +143,6 @@ class FolderPermissions:
PARENT_PERMISSIONS = [
# Typically granted with `roles/resourcemanager.projectCreator`
"resourcemanager.projects.create",

# Typically granted with `roles/resourcemanager.folderViewer`
"resourcemanager.folders.get",
]

def __init__(self, folder_id, parent=False):
Expand Down
4 changes: 0 additions & 4 deletions test/scripts/preconditions/test_preconditions.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ def test_base_permissions(self):
org_perms.permissions,
[
"resourcemanager.organizations.get",
"iam.serviceAccounts.setIamPolicy",
]
)

Expand All @@ -123,7 +122,6 @@ def test_shared_vpc_permissions(self):
org_perms.permissions,
[
"resourcemanager.organizations.get",
"iam.serviceAccounts.setIamPolicy",
"compute.subnetworks.setIamPolicy",
"compute.organizations.enableXpnResource",
]
Expand All @@ -135,7 +133,6 @@ def test_parent_permissions(self):
org_perms.permissions,
[
"resourcemanager.organizations.get",
"iam.serviceAccounts.setIamPolicy",
"resourcemanager.projects.create"
]
)
Expand All @@ -155,7 +152,6 @@ def test_parent_permissions(self):
folder_perms.permissions,
[
"resourcemanager.projects.create",
"resourcemanager.folders.get",
]
)

Expand Down

0 comments on commit 3950915

Please sign in to comment.