Optionally Enable "redis.googleapis.com" Service #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the "redis.googleapis.com" service on the targeted project if the `enable_apis` variable is true. Defaults to `true` with what we consider to be the most basic module usecase in mind - a brand new project is targeted and service enablement is not already managed by other means.
adrienthebo
suggested changes
Jan 16, 2019
variables.tf
Outdated
|
|
||
| variable "enable_apis" { | ||
| description = "Enable required APIs for Cloud Memorystore." | ||
| default = true |
There was a problem hiding this comment.
Boolean variable defaults should be quoted because terraform will coerce true to 1, and this behavior will change on 0.12.
main.tf
Outdated
| } | ||
|
|
||
| resource "google_project_service" "redis" { | ||
|
|
There was a problem hiding this comment.
Heads up - terraform fmt will remove this space, so we might as well remove it in the PR.
|
@trotttrotttrott Please run |
Terraform docs recommend use of strings for boolean values to avoid caveats in the conversion process.
|
@adrienthebo I've addressed your comments. Please take another look when you have a chance! |
pkatsovich
pushed a commit
to recurly/terraform-google-memorystore
that referenced
this pull request
Aug 2, 2020
…odules/ludo-simple-example-and-tests Fix simple example and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the "redis.googleapis.com" service on the targeted project if the
enable_apisvariable istrue. Defaults totruewith what we consider to be the most basic module use case in mind - a brand new project is targeted and service enablement is not already managed by other means.Integration tests now pass successfully when targeting a new, pristine project. As previously or with
enable_apisset tofalse, tests will fail run against a pristine project withError 403: Google Cloud Memorystore for Redis API has not been used in project <PROJECT_ID> before or it is disabled....