Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial update of CI testing setup #14

Closed
wants to merge 6 commits into from
Closed

Initial update of CI testing setup #14

wants to merge 6 commits into from

Conversation

milesmatthias
Copy link

@milesmatthias milesmatthias commented Oct 25, 2019 •
edited
Loading

Fixes #12

@morgante
Copy link
Contributor

@milesmatthias Looks like a duplicate of #13?

@milesmatthias
Copy link
Author

@morgante yes, I didn't see #13 before submitting this work, but it looks like that is in draft form, whereas mine is ready to merge.

@morgante morgante self-assigned this Oct 25, 2019
@morgante
Copy link
Contributor

@milesmatthias Can you configure the Cloud Build checks for this before we merge?

@milesmatthias
Copy link
Author

@morgante yup, adding those.

@morgante
Copy link
Contributor

@milesmatthias Looks like this is being handled in #13, you can drop work on it for now.

@milesmatthias
Copy link
Author

Thanks @morgante, will do.

@morgante morgante closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante Awaiting requested review from morgante

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

Assignees

@morgante morgante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing based on new approach
2 participants
@milesmatthias @morgante