fix: Lazy eval data source only if enabled (#76)

* eval data if enabled * add a simple test for disabled path * test with an unused api
terraform-google-modules · Sep 2, 2020 · f2c9913 · f2c9913
1 parent 37b52e8
commit f2c9913
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/examples/simple_example/main.tf b/examples/simple_example/main.tf
@@ -27,3 +27,14 @@ module "cli" {
   create_cmd_body  = "services enable youtube.googleapis.com --project ${var.project_id}"
   destroy_cmd_body = "services disable youtube.googleapis.com --project ${var.project_id}"
 }
+
+module "cli-disabled" {
+  source = "../.."
+
+  platform              = "linux"
+  additional_components = ["kubectl", "beta"]
+
+  enabled          = false
+  create_cmd_body  = "services enable datastore.googleapis.com --project ${var.project_id}"
+  destroy_cmd_body = "services disable datastore.googleapis.com --project ${var.project_id}"
+}
diff --git a/main.tf b/main.tf
@@ -22,7 +22,7 @@ locals {
   gcloud_bin_abs_path  = abspath(local.gcloud_bin_path)
   components           = join(",", var.additional_components)
 
-  download_override = data.external.env_override[0].result.download
+  download_override = var.enabled ? data.external.env_override[0].result.download : ""
   skip_download     = local.download_override == "always" ? false : (local.download_override == "never" ? true : var.skip_download)
 
   gcloud              = local.skip_download ? "gcloud" : "${local.gcloud_bin_path}/gcloud"

diff --git a/test/integration/simple_example/controls/gcloud.rb b/test/integration/simple_example/controls/gcloud.rb
@@ -19,5 +19,6 @@
     its(:exit_status) { should eq 0 }
     its(:stderr) { should eq "" }
     its(:stdout) { should match "youtube.googleapis.com" }
+    its(:stdout) { should_not match "datastore.googleapis.com" }
   end
 end