Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible #35

Closed
ivankorn opened this issue Aug 14, 2019 · 0 comments · Fixed by #31
Closed

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible #35

ivankorn opened this issue Aug 14, 2019 · 0 comments · Fixed by #31
Assignees
@ivankorn
Labels
bug Something isn't working enhancement New feature or request

Comments

@ivankorn
Copy link
Contributor

Related #32 #28

cc: @aaron-lane @morgante @kopachevsky @nick4fake
@ivankorn ivankorn added bug Something isn't working enhancement New feature or request labels Aug 14, 2019
@ivankorn ivankorn self-assigned this Aug 14, 2019
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 15, 2019
@ivankorn
Migrate modules to 0.12 and make the rest of the code base 0.12-compa…
eef74e8 
…tible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constaints
- Updated README files
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 15, 2019
@ivankorn
Migrate modules to 0.12 and make the rest of the code base 0.12-compa…
544d3f5 
…tible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constaints
- Updated README files
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 15, 2019
@ivankorn
Migrate modules to 0.12 and make the rest of the code base 0.12-compa…
302817e 
…tible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constaints
- Updated README files
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
ebf1c72 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)
@ivankorn ivankorn mentioned this issue Aug 19, 2019
Closed
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
70a0da8 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
3fe1ebe 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf with adding hashed image into instance_name
- Updated examples/simple_instance/outputs.tf with adding hashed image into instance_name
@ivankorn ivankorn mentioned this issue Aug 19, 2019
Merged
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
1936ae6 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
cdc9ec7 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 19, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
221f9d7 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 20, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
67b616e 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master
- Adjusted .gitingore

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
ivankorn added a commit to ivankorn/terraform-google-container-vm that referenced this issue Aug 20, 2019
@ivankorn
Linters fail on master terraform-google-modules#32
185ec55 
- Removed outdated doc_generator
- Added missing helper scripts
- Removed outdated docker linter
- Fixed flake8 errors reported in terraform-google-modules#32
- Fixed broken simlinks(fixes terraform fmt terraform-google-modules#32)
- Updated shared tfvars
- Updated README files
- Fixed trailing white-space from master
- Adjusted .gitingore

Migrate modules to 0.12 and make the rest of the code base 0.12-compatible terraform-google-modules#35

- Migrated modules to 0.12 syntax
- Added variable types constraints
- Updated README
- Removed outdated check_docker make target
- Added a temporary workgaround for terraform-google-modules#28 (skip not migrated files in `find_files`)

Updating image inside the example doesn't cause container to restart terraform-google-modules#29

- Updated examples/simple_instance/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/simple_instance/outputs.tf by reflecting the change above
- Updated examples/instance_with_attached_disk/main.tf by introducing local.instance_name and adding substring of contianer image hash into instance_name
- Updated examples/instance_with_attached_disk/outputs.tf by reflecting the change above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivankorn ivankorn

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ivankorn