Use new VPC networks in private connection tests #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:9da4e3ec45d10f9f585812c3722f241c182db087] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit d3fb30a
into
terraform-google-modules:master
1 check passed
modular-magician
deleted the
downstream-pr-9da4e3ec45d10f9f585812c3722f241c182db087
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#17384
The test currently uses a bootstrapped network for creating private connections. When a private connection creation fails, it leaves orphan resources linked to the peered subnet which prevents future runs from using that subnet.
Derived from GoogleCloudPlatform/magic-modules#11175