Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Correct enable_mfa_enforcement spelling #404

Conversation

booi
Copy link
Contributor

@booi booi commented Jul 3, 2023

Description

correct spelling of the enable_mfa_enforcement option in iam-group-with-policies

Motivation and Context

Fixes #377
Closes #401

Breaking Changes

yes, anybody with the old spelling enable_mfa_enforcment will be required to update their code to the new option.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • [ X ] I have executed pre-commit run -a on my pull request
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

@booi booi changed the title Fix enable_mfa_enforcement spelling fix: enable_mfa_enforcement spelling Jul 3, 2023
@antonbabenko antonbabenko changed the title fix: enable_mfa_enforcement spelling feat: Fixed spelling in variable name enable_mfa_enforcement Jul 3, 2023
@booi booi changed the title feat: Fixed spelling in variable name enable_mfa_enforcement fix: Correct enable_mfa_enforcement spelling Jul 3, 2023
@antonbabenko antonbabenko changed the title fix: Correct enable_mfa_enforcement spelling feat: Correct enable_mfa_enforcement spelling Jul 4, 2023
@antonbabenko antonbabenko merged commit 54b7165 into terraform-aws-modules:master Jul 4, 2023
antonbabenko pushed a commit that referenced this pull request Jul 4, 2023
## [5.27.0](v5.26.0...v5.27.0) (2023-07-04)

### Features

* Correct enable_mfa_enforcement spelling ([#404](#404)) ([54b7165](54b7165))
@antonbabenko
Copy link
Member

This PR is included in version 5.27.0 🎉

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFA enforcement be default now? Enforcement misspelled in input variable
2 participants