Skip to content

Commit

Permalink
Merge pull request #171 from terra-money/fix/ibc-denom-trace
Browse files Browse the repository at this point in the history
fix query return format of denomTrace[s]
  • Loading branch information
yys authored Nov 11, 2021
2 parents 55c4b06 + 5b30175 commit dcf0891
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 7 deletions.
20 changes: 16 additions & 4 deletions src/client/lcd/api/IbcTransferAPI.spec.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,30 @@
import { APIRequester } from '../APIRequester';
import { APIRequester, Pagination } from '../APIRequester';
import { IbcTransferAPI } from './IbcTransferAPI';
import { DenomTrace } from '../../../core/ibc-transfer/DenomTrace';

const c = new APIRequester('https://bombay-lcd.terra.dev/');
const ibctx = new IbcTransferAPI(c);

describe('IbcTransferAPI', () => {
/*
describe('denomTrace', () => {

it('denomTraces', async () => {
const denomTraces = await ibctx.denomTraces().then(v => v[0])
denomTraces.forEach(function (denomTrace: DenomTrace.Data) {
expect(denomTrace.path).toMatch("transfer/channel-");
expect(denomTrace.base_denom).not.toBeUndefined();
});
*/
});

it('denomTrace', async () => {
const denomTrace = await ibctx.denomTrace('B8AF5D92165F35AB31F3FC7C7B444B9D240760FA5D406C49D24862BD0284E395')
expect(denomTrace.path).toEqual("transfer/channel-4");
expect(denomTrace.base_denom).toEqual("uluna");
});

it('params', async () => {
const param = await ibctx.parameters();
expect(param.send_enabled).toEqual(expect.any(Boolean));
expect(param.receive_enabled).toEqual(expect.any(Boolean));
});

});
7 changes: 4 additions & 3 deletions src/client/lcd/api/IbcTransferAPI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ export namespace IbcTransferParams {
export class IbcTransferAPI extends BaseAPI {
/** Gets a denomTrace for the hash */
public async denomTrace(hash: string): Promise<DenomTrace> {
return await this.c.get<DenomTrace>(

return this.c.get<{ denom_trace: DenomTrace.Data }>(
`/ibc/apps/transfer/v1/denom_traces/${hash}`
);
).then(d => DenomTrace.fromData(d.denom_trace));
}

/** Gets a list of denomTraces */
Expand All @@ -32,7 +33,7 @@ export class IbcTransferAPI extends BaseAPI {
`/ibc/apps/transfer/v1/denom_traces`,
params
)
.then(d => [d.denom_traces, d.pagination]);
.then(d => [d.denom_traces.map(DenomTrace.fromData), d.pagination]);
}

/* not supoorted
Expand Down

0 comments on commit dcf0891

Please sign in to comment.