Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of docker buildx #3

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Remove the usage of docker buildx #3

merged 1 commit into from
Feb 7, 2023

Conversation

edmondchuc
Copy link
Contributor

Docker Buildx is only required when creating multi-arch container images. Since we're not doing that here, it's better to not use it.

If we do use it, we have to set provenance = false in the docker/build-push-action step due to an issue with the image metadata when pushed to GitHub Container Registry. See docker/build-push-action#778 for context. This issue was introduced in v3.3.0 of docker/build-push-action.

@edmondchuc edmondchuc requested a review from gweis January 27, 2023 01:45
@edmondchuc
Copy link
Contributor Author

This PR is also bringing to light the recent release of SQLAlchemy v2's incompatibility with Flask-SQLAlchemy.

@gweis
Copy link
Contributor

gweis commented Jan 27, 2023

not quite as straightforward as updating Flask-SQLAlchemy .... Flask-SQLALchemy has been fixed last October. ... however that fix kinda came along with a requirement to update Flask to >= 2.2 (which we pin to < 2.1.0) ...
so ...either we pin sqlalchemy to < 3.0.0 or we update Flask to latest version ... either way should fix this dependency problem (I guess Flask 2.2 upgrade requires a bit of testing as well)

@gweis
Copy link
Contributor

gweis commented Jan 27, 2023

(and yes .. .this whole docker buildx, DOCKER_BUILDKIT=1, etc... is a bit messy, and depends too much on the builders available to your environment (IMO)

@gweis gweis merged commit 3a0b711 into main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants