Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts/setup-ubuntu): retarget symbolic link to prepare for aosp-libs package #23054

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

robertkirkman
Copy link
Contributor

@robertkirkman robertkirkman commented Jan 28, 2025

@Grimler91
Copy link
Member

Please add both symlinks, and then we can remove the old one after the bionic-host PR has been merged. This way bionic-host/aosp-libs is buildable even in the transition period

@robertkirkman robertkirkman changed the title chore(scripts/setup-ubuntu): rename symbolic link to prepare for aosp-libs package chore(scripts/setup-ubuntu): retarget symbolic link to prepare for aosp-libs package Jan 29, 2025
@robertkirkman
Copy link
Contributor Author

robertkirkman commented Jan 29, 2025

I am sorry for the inaccurate title, technically, using exact terminology, this is "retargeting" not "renaming" the symbolic link,
the "name" has to remain "/system" the entire time, and, what you suggested is a good idea, I wish I knew a way to do that, but I am not sure if that is possible.
Do you know if there is a way to implement what you are describing, a symbolic link that can target two different folders at the same time?

I could try to use something like this, but I think this probably wouldn't work, I will still test this, if this is what you mean:

$SUDO ln -sf /data/data/com.termux/files/usr/opt/bionic-host /system
$SUDO ln -sf /data/data/com.termux/files/usr/opt/aosp /data/data/com.termux/files/usr/opt/bionic-host

@robertkirkman
Copy link
Contributor Author

robertkirkman commented Jan 29, 2025

I tried those commands, and unfortunately, doing that does cause this error

mkdir: cannot create directory ‘/data/data/com.termux/files/usr/opt/bionic-host’: File exists

at this line of the current bionic-host package.

mkdir -p "${TERMUX_PREFIX}/opt/bionic-host/usr/icu"

I'll think about this problem for a while and try to find out if there is any kind of solution that meets the continuous uptime requirements.

@robertkirkman robertkirkman marked this pull request as draft January 29, 2025 13:34
@Grimler91
Copy link
Member

Ah, right, sorry, I read to fast and thought the symlinks were the other way around. Nevermind! Let's get this in, should be pretty safe since only bionic-host is affected..

@Grimler91 Grimler91 force-pushed the termux-aosp-rename-symlink branch from b3c2e00 to 12b5775 Compare January 29, 2025 18:26
@Grimler91 Grimler91 merged commit 12b5775 into termux:master Jan 29, 2025
@Grimler91
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants