Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(main/libx265): 4.0 #22492

Merged
merged 2 commits into from
Dec 13, 2024
Merged

bump(main/libx265): 4.0 #22492

merged 2 commits into from
Dec 13, 2024

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented Dec 9, 2024

  • Test command:
    • ffmpeg -i Big_Buck_Bunny_360_10s_1MB.webm -vcodec libx265 -crf 28 output.mp4
  • Before:
    • encoded 300 frames in 18.75s (16.00 fps), 395.58 kb/s, Avg QP:33.43
  • After:
    • encoded 300 frames in 15.53s (19.32 fps), 395.58 kb/s, Avg QP:33.43

@Biswa96
Copy link
Member Author

Biswa96 commented Dec 9, 2024

This creates an update cycle. Current handbrake version can not be built with newer libx265 and older ffmpeg v6. So, ffmpeg, libx264 and handbrake need to be built at once.

robertkirkman added a commit to robertkirkman/termux-packages that referenced this pull request Dec 10, 2024
CLI building, GTK GUI not building yet
fork of termux#22492
@robertkirkman
Copy link
Contributor

robertkirkman commented Dec 10, 2024

@Biswa96 I forked this PR and uploaded a version I made to this branch,
master...robertkirkman:termux-packages:bump-libx265-ffmpeg-handbrake
I think this does what you want, this is

  • libx265 4.1
  • ffmpeg 7.1
  • handbrake 1.9.0
  • all reverse dependencies' revisions bumped
  • 8 packages require additional patches to build with ffmpeg 7, which are included here
    • aubio: patch copied from Arch Linux
    • gpac: patch cherry-picked from upstream development repository
    • minidlna: patch copied from Arch Linux
    • mplayer: some patches copied from Arch Linux, others cherry-picked from upstream development repository
    • pianobar: patch cherry-picked from upstream development repository
    • vlc: patch copied from Debian Testing
    • deadbeef: patch cherry-picked from upstream development repository
    • oshu: I wrote and tested this patch on my own, including in-game on-device audio playback testing. I could not find any other preexisting implementation of ffmpeg 7 support for this app.

You can use this branch to copy things from into this PR, or I could make it a separate PR, or if there are too many packages revbumped at once in the branch, maybe I should open a group of numbered PRs so that not too many packages are built at once.

@Biswa96
Copy link
Member Author

Biswa96 commented Dec 10, 2024

Thank you. I shall roll the update slowly as mentioned in the issue tracker.

@TomJo2000
Copy link
Member

@Biswa96 I forked this PR and uploaded a version I made to this branch, master...robertkirkman:termux-packages:bump-libx265-ffmpeg-handbrake

I'll start a local validation run on this shortly.
Is that all of the reverse dependencies?

@robertkirkman
Copy link
Contributor

robertkirkman commented Dec 11, 2024

@Biswa96 I forked this PR and uploaded a version I made to this branch, master...robertkirkman:termux-packages:bump-libx265-ffmpeg-handbrake

I'll start a local validation run on this shortly. Is that all of the reverse dependencies?

Technically, kdenlive is marked as depending on fflplay , and the ffplay package does contain an additional copy of libavdevice.so at $PREFIX/opt/ffplay/lib/libavdevice.so. I don't really think kdenlive is directly linked to or ever directly dlopen()s that file, I think it is more likely that it only popen()s $PREFIX/bin/ffplay or similar operations that do not depend on linking symbols, but to be on the safe side, now I added a revision bump for it to the branch. I think that after that, all reverse dependencies for all four version-bumped packages (ffmpeg, ffplay, libx265 and handbrake) are marked with revision bumps and cross-compile on my system when the new packages are installed in the $TERMUX_PREFIX. Let me know if you notice any I missed.

@TomJo2000
Copy link
Member

I'll try to get a full validation run started after I get some sleep.

@truboxl
Copy link
Contributor

truboxl commented Dec 11, 2024

I forked this PR and uploaded a version I made to this branch, master...robertkirkman:termux-packages:bump-libx265-ffmpeg-handbrake

All seems to build fine except handbrake fails lint-packages.sh

@Biswa96 Biswa96 changed the title bump(main/libx265): 4.1 bump(main/libx265): 4.0 Dec 11, 2024
@Biswa96 Biswa96 merged commit e67fdc7 into termux:master Dec 13, 2024
8 checks passed
@Biswa96 Biswa96 deleted the libx265 branch December 13, 2024 13:21
@Biswa96 Biswa96 mentioned this pull request Dec 13, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants