-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for node 6 #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should add a promise-based solution manually. Babel always makes a mess of async rewrites, or at least embeds a sizable runtime/mapper.
Manual rewrite would be much simpler to maintain than the sync version tbh.
Also, you never want to use stage-* anymore. Tip comes from Babel team. Stages change too often and typically only want an item or two from the set.
Not a fan of the dynamic require personally. Users should be explicit in what they use, just like tiny-glob/sync
.
Just my thoughts while on the go~
Thanks for the review Luke. Is async/await the only thing we need Babel for at the moment? If so, I agree a manual rewrite would be preferable |
@lukeed @terkelg,
There is no sync version, this PR is only about supporting Node 6 without changing any behavior. |
Don't mind me 🙃 Reviewing while grocery shopping is bad idea. I thought I was getting emails about the |
Thanks @ranyitz! I'll have a look tonight |
Summary
This PR Fixes #64 and adds node 6 support
babel
and transpile all files fromlib
todist
dist
to.gitignore
dist
&index.js
to the files array inpackage.json
so they will be available on next publish.index.js
file on the root, which routes betweenlib
anddist
according to the user's Node version.babel-register
but then I realized that I couldn't test that they actually run on node 6.Test Plan
All tests are passing on CI when using Node 6