Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Random Library Selection with Publish Filter #78

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Apr 17, 2024

Prioritize Publishing Libraries for Random Selection

This pull request modifies the code for selecting random libraries from a list.

Current Behavior:

The code previously selected random libraries from the list by filtering out BOM (Bill of Materials) libraries but selecting any remaining library regardless of its publishing status.

Change:

  • The code now filters out BOM libraries and libraries that don't have the publish flag set to true.
  • This ensures that only libraries intended for publishing are considered when selecting random library candidates.
  • Two separate Random instances with distinct seeds (0 and 1) are still used to maintain unique random selections for each variable (libraryByVersion and library).

Benefits:

  • Ensures random selection prioritizes libraries actively intended for publishing.
  • Avoids the selection of non-publishing libraries that might not be relevant for the use case.

@teogor teogor added the @enhancement New feature or request label Apr 17, 2024
@teogor teogor added this to the 1.0.1 milestone Apr 17, 2024
@teogor teogor self-assigned this Apr 17, 2024
@teogor teogor merged commit a2501aa into main Apr 17, 2024
5 checks passed
@zeobot zeobot bot deleted the enhancement/publish-filter-random-library branch April 17, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant