Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in MavenPublish displayName getter #41

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Feb 6, 2024

This pull request addresses an issue where the displayName getter in the MavenPublish interface creates an infinite loop when calling the gets function with a nested selector referencing itself.

Details:

The bug occurs when this call chain happens:
1. displayName getter is called.
2. Within the getter, gets is called with a selector that retrieves data necessary for display name construction.
3. If the selector indirectly or directly references displayName, an infinite loop is triggered.

Potential Impact:

  • This fix prevents the infinite loop and ensures correct retrieval of the displayName.
  • Downstream systems relying on the display name will now receive accurate data.

Additional Notes:

@teogor teogor self-assigned this Feb 6, 2024
@teogor teogor merged commit 77e0c46 into main Feb 6, 2024
4 checks passed
@zeobot zeobot bot deleted the bugfix/mavenpublish-infinite-loop-displayname branch February 6, 2024 14:52
@teogor teogor added this to the 1.0.0-beta01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant