Files App: Add a flag for rename feature to flag descriptions

This CL adds a flag that enables external drive rename action in the context menu. The flag is added to flag descriptions and as a result, it is visible under chrome://flags. BUG=274041 Change-Id: Ia83b12daab124b0f664699b432d48c6138410678 Reviewed-on: https://chromium-review.googlesource.com/644667 Reviewed-by: Naoki Fukino <[email protected]> Commit-Queue: Klemen Kozjek <[email protected]> Cr-Commit-Position: refs/heads/master@{#499134}
tenta-browser · Sep 1, 2017 · f2b30e4 · f2b30e4
1 parent 0c0059c
commit f2b30e4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -3421,6 +3421,13 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(base::kSyzyAsanDCheckIsFatalFeature)},
 #endif  // DCHECK_IS_ON() && defined(SYZYASAN)
 
+#if defined(OS_CHROMEOS)
+    {"enable-external-drive-rename",
+     flag_descriptions::kEnableExternalDriveRename,
+     flag_descriptions::kEnableExternalDriveRenameDescription, kOsCrOS,
+     SINGLE_VALUE_TYPE(chromeos::switches::kEnableExternalDriveRename)},
+#endif  // defined(OS_CHROMEOS)
+
     // NOTE: Adding new command-line switches requires adding corresponding
     // entries to enum "LoginCustomFlags" in histograms/enums.xml. See note in
     // enums.xml and don't forget to run AboutFlagsHistogramTest unit test.

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -2299,6 +2299,11 @@ const char kEnableEncryptionMigrationDescription[] =
     "If enabled and the device supports ARC, the user will be asked to update "
     "the encryption of user data when the user signs in.";
 
+const char kEnableExternalDriveRename[] = "Enable external drive rename";
+const char kEnableExternalDriveRenameDescription[] =
+    "If enabled, external removable drives will get 'Rename' action in the "
+    "context menu";
+
 const char kEnableImeMenuName[] = "Enable opt-in IME menu";
 const char kEnableImeMenuDescription[] =
     "Enable access to the new IME menu in the Language Settings page.";

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -1409,6 +1409,9 @@ extern const char kEnableEhvInputDescription[];
 extern const char kEnableEncryptionMigrationName[];
 extern const char kEnableEncryptionMigrationDescription[];
 
+extern const char kEnableExternalDriveRename[];
+extern const char kEnableExternalDriveRenameDescription[];
+
 extern const char kEnableImeMenuName[];
 extern const char kEnableImeMenuDescription[];
 

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -23893,6 +23893,7 @@ from previous Chrome versions.
   <int value="691020108" label="NTPCondensedTileLayout:disabled"/>
   <int value="693012666" label="QuickUnlockPin:disabled"/>
   <int value="694985670" label="OmniboxUIExperimentNarrowDropdown:disabled"/>
+  <int value="695385040" label="enable-external-drive-rename"/>
   <int value="696600628" label="VibrateRequiresUserGesture:disabled"/>
   <int value="698809951" label="WebRtcHWVP8Encoding:enabled"/>
   <int value="705713283" label="EasyUnlockPromotions:disabled"/>