[Home] Fix app menu crash on JellyBean

JellyBean crashes if a header is added to a ListView after the adapter
has been set. Switch the order of adding the header and setting the
adapter.

BUG=761726

[email protected]

Change-Id: I1cfafe3b437667469d28fc9f3cc79ed0137a1faf
Reviewed-on: https://chromium-review.googlesource.com/650626
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#499674}
Reviewed-on: https://chromium-review.googlesource.com/653419
Reviewed-by: Theresa <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#49}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

@@ -255,13 +255,16 @@ void show(Context context, final View anchorView, boolean isByPermanentButton,
         ViewGroup contentView =
                 (ViewGroup) LayoutInflater.from(context).inflate(R.layout.app_menu_layout, null);
         mListView = (ListView) contentView.findViewById(R.id.app_menu_list);
-        mListView.setAdapter(mAdapter);
 
         int footerHeight =
                 inflateFooter(footerResourceId, contentView, menuWidth, highlightedItemId);
         int headerHeight =
                 inflateHeader(headerResourceId, headerOnClickListener, context, menuWidth);
 
+        // Set the adapter after the header is added to avoid crashes on JellyBean.
+        // See crbug.com/761726.
+        mListView.setAdapter(mAdapter);
+
         int popupHeight = setMenuHeight(menuItems.size(), visibleDisplayFrame, screenHeight,
                 sizingPadding, footerHeight, headerHeight, anchorView);
         int[] popupPosition = getPopupPosition(mCurrentScreenRotation, visibleDisplayFrame,