Fix Ruff B008 errors #6952
Fix Ruff B008 errors #6952
Conversation
| @@ -140,8 +140,10 @@ def verify_beam_pipeline_arg(a: int) -> OutputDict(b=float): # pytype: disable= | |||
|
|
|||
| def verify_beam_pipeline_arg_non_none_default_value( | |||
| a: int, | |||
| beam_pipeline: BeamComponentParameter[beam.Pipeline] = beam.Pipeline(), | |||
| beam_pipeline: BeamComponentParameter[beam.Pipeline] = 0, | |||
There was a problem hiding this comment.
beam_pipeline: BeamComponentParameter[beam.Pipeline] = None looks better
There was a problem hiding this comment.
Since the test case is to verify the default value to not none, the test case fails with below error:
FAILED tfx/dsl/component/experimental/decorators_test.py::ComponentDecoratorTest::testBeamPipelineDefaultIsNotNoneFails - TypeError: Argument a should be a Channel of type <class 'tfx.types.standard_artifacts.Integer'> (got 1)
Hence I have assigned default value as 0.
There was a problem hiding this comment.
Oh I see. The typing error is pretty clear. You cannot assign an integer to other type.
If it is to avoid B008, then how's about doing it in this way?
_TestBeamPipelineArgs = ['--my_testing_beam_pipeline_args=foo']
_TestEmptyBeamPipeline = beam.Pipeline() # <- Newly added
...
def verify_beam_pipeline_arg_non_none_default_value(
a: int,
beam_pipeline: BeamComponentParameter[beam.Pipeline] = _TestEmptyBeamPipeline,
) -> OutputDict(b=float): # pytype: disable=invalid-annotation,wrong-arg-types
del beam_pipeline
return {'b': float(a)}There was a problem hiding this comment.
Thanks! That works. I have updated.
| @@ -140,8 +140,10 @@ def verify_beam_pipeline_arg(a: int) -> TypedDict('Output6', dict(b=float)): # | |||
|
|
|||
| def verify_beam_pipeline_arg_non_none_default_value( | |||
| a: int, | |||
| beam_pipeline: BeamComponentParameter[beam.Pipeline] = beam.Pipeline(), | |||
| beam_pipeline: BeamComponentParameter[beam.Pipeline] = 0, | |||
There was a problem hiding this comment.
Error:
FAILED tfx/dsl/component/experimental/decorators_typeddict_test.py::ComponentDecoratorTest::testBeamPipelineDefaultIsNotNoneFails - TypeError: Argument a should be a Channel of type <class 'tfx.types.standard_artifacts.Integer'> (got 1)
#6945