Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename documentation file WordShape.md to WordShape_cls.md. The problem is on MacOS (and maybe Windows) this filename collides with wordshape.md, because the filesystem does not differentiate cases for the files. This is purely a QOL change for anybody checking out the library on a non-Linux platform. Fix #361. #479

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

tf-text-github-robot
Copy link
Collaborator

@tf-text-github-robot tf-text-github-robot commented Dec 21, 2020

Rename documentation file WordShape.md to WordShape_cls.md. The problem is on MacOS (and maybe Windows) this filename collides with wordshape.md, because the filesystem does not differentiate cases for the files. This is purely a QOL change for anybody checking out the library on a non-Linux platform. Fix #361.

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@tf-text-github-robot tf-text-github-robot force-pushed the test_348496513 branch 2 times, most recently from 4915a9a to dbab699 Compare December 21, 2020 20:09
@tf-text-github-robot tf-text-github-robot changed the title Rename documentation file WordShape.md to WordShape_cls.md. The problem is on MacOS (and maybe Windows) this filename collides with wordshape.md, because the filesystem does not differentiate cases for the files. This is purely a QOL change for anybody checking out the library on a non-Linux platform. Rename documentation file WordShape.md to WordShape_cls.md. The problem is on MacOS (and maybe Windows) this filename collides with wordshape.md, because the filesystem does not differentiate cases for the files. This is purely a QOL change for anybody checking out the library on a non-Linux platform. Fix #361. Dec 21, 2020
…em is on MacOS (and maybe Windows) this filename collides with wordshape.md, because the filesystem does not differentiate cases for the files. This is purely a QOL change for anybody checking out the library on a non-Linux platform. Fix #361.

PiperOrigin-RevId: 348508297
@tf-text-github-robot tf-text-github-robot merged commit d57e6fd into master Dec 21, 2020
@tf-text-github-robot tf-text-github-robot deleted the test_348496513 branch December 21, 2020 20:30
@github-pages github-pages bot temporarily deployed to github-pages December 21, 2020 20:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building 2.1 from source on Mac (10.15.5)
2 participants