pix2pix

[s1ddok]

U-Net based generator model with Facades dataset support. Implementation is a bit rough, but I would love to adjust it in order to be merged into the repo, would love to hear a feedback!

[BradLarson]

That's great, thanks for working on this. As a first step, would you be able to add license headers to all files (see the other models for examples on how this is done) and format these according to the Google Style Guide? For the latter, we use swift-format and have our formatting style codified in the .swift-format file here.

Beyond that, we'd probably want to integrate this into the project's main Package.swift, rather than have it exist as a separate sub-package. At some point, we might even be able to generalize the U-Net layers into something that can be used across examples, but I think this will be fine for now.

I have some smaller comments that I can post inline with the code, but those are the larger formatting issues that come to mind.

[s1ddok]

Thanks for feedback, I will add the headers and comply with the swift-format

[dabrahams]

@s1ddok gentle ping?

[s1ddok]

@dabrahams I’m somewhat purposefully stalling here, I want to get CycleGAN PR to be merged first (that one appeared to be a more mature implementation) and then reuse some code between the two.

[s1ddok]

@BradLarson @dabrahams please take a look at updates. I've tried to combine comments from both this and #400. I think the implementations are very close. Please let me know if I can do anything else in order for this to be merged.

[s1ddok]

@BradLarson @dabrahams sorry for bumping this too often, just don't want this to get outdated too much, I'm all yours for fixes while I'm still in context of this stuff, so please take a look if you have a moment, thanks!

[s1ddok]

@BradLarson fixed!

[s1ddok]

@BradLarson Sorry I completely forgot about outdated README, I've accepted all your grammar fixes and removed all of TensorBoard mentions.

[BradLarson]

Thanks for being patient with the suggested changes, and for putting in the hard work to make this go. The results look great, and a general U-Net implementation will be useful for many applications. Really appreciate the work on this.