Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displayed the Download Size for Each dataset #141

Closed
wants to merge 1 commit into from
Closed

Displayed the Download Size for Each dataset #141

wants to merge 1 commit into from

Conversation

ParthS007
Copy link
Contributor

@ParthS007 ParthS007 commented Mar 4, 2019 •
edited
Loading

Fixes #120

  • Display the download size for each dataset.
  • I have converted the size to MB for human-readable Formatting.
  • Added an extra column and created a Markdown table for it.

@Conchylicultor @dynamicwebpaige Please review and let me know if I have to do any changes.

Thanks

@googlebot googlebot added the cla: yes Author has signed CLA label Mar 4, 2019
@ParthS007 ParthS007 mentioned this pull request Mar 4, 2019
Closed
@ParthS007
Copy link
Contributor Author

ParthS007 commented Mar 4, 2019 •
edited
Loading

@rsepassi @cyfra @tfds-copybara Please review and let me know if I have to do any changes.

Thanks

cyfra
cyfra suggested changes Mar 5, 2019
View reviewed changes
docs/datasets.md
@@ -29,47 +29,69 @@ np_datasets = tfds.as_numpy(datasets)
## All Datasets

* [`audio`](#audio)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated.

You should change the generator instead: scripts/document_datasets.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyfra Should I make a new PR for that and close this one or make changes here only?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I think #145 is already accomplishing this so we could probably close this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 👍

@ParthS007 ParthS007 closed this Mar 5, 2019
@ParthS007 ParthS007 deleted the datasetSize branch March 5, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Conchylicultor left review comments

@cyfra cyfra cyfra requested changes

@vijaysinghkadam vijaysinghkadam vijaysinghkadam approved these changes

Assignees
No one assigned
Labels
cla: yes Author has signed CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ParthS007 @Conchylicultor @cyfra @vijaysinghkadam @googlebot