Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Remove hard installation dep #974

Merged
merged 6 commits into from
Jan 30, 2020
Merged

BLD: Remove hard installation dep #974

merged 6 commits into from
Jan 30, 2020

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Jan 30, 2020 •
edited
Loading

Closes #864 #965

@seanpmorgan seanpmorgan added the blocked Pending something elses completion label Jan 30, 2020
@seanpmorgan seanpmorgan requested a review from a team as a code owner January 30, 2020 01:09
@boring-cyborg boring-cyborg bot added the build label Jan 30, 2020
@seanpmorgan
Copy link
Member Author

Since this is major request and large change we should consider a 0.8 release after we finish PRs that are finalizing.

@seanpmorgan seanpmorgan changed the title [WIP] Remove hard installation dep [WIP] BLD: Remove hard installation dep Jan 30, 2020
gabrieldemarmiesse
gabrieldemarmiesse reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, happy to see it :)

tensorflow_addons/__init__.py Outdated Show resolved Hide resolved
@boring-cyborg boring-cyborg bot added the test-cases Related to Addons tests label Jan 30, 2020
@seanpmorgan seanpmorgan changed the title [WIP] BLD: Remove hard installation dep BLD: Remove hard installation dep Jan 30, 2020
@seanpmorgan seanpmorgan removed the blocked Pending something elses completion label Jan 30, 2020
gabrieldemarmiesse
gabrieldemarmiesse reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

configure.py Show resolved Hide resolved
build_deps/check_deps.py Outdated Show resolved Hide resolved
@gabrieldemarmiesse
Copy link
Member

Thanks for the pull request, looks good to me!

@gabrieldemarmiesse gabrieldemarmiesse merged commit 37f0fd9 into tensorflow:master Jan 30, 2020
@seanpmorgan seanpmorgan deleted the bld-remove-dependency branch January 30, 2020 16:48
@seanpmorgan seanpmorgan mentioned this pull request Jan 31, 2020
Closed
failure-to-thrive pushed a commit to failure-to-thrive/addons that referenced this pull request Feb 1, 2020
@seanpmorgan
BLD: Remove hard installation dep (tensorflow#974)
875cf2f 
* Remove hard installation dep

* Update TF required

* Update build for no dependency

* Move to utils

* Remove sys exit
@bhack bhack mentioned this pull request Aug 22, 2020
Closed
@tgaddair tgaddair mentioned this pull request Aug 24, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
build cla: yes test-cases Related to Addons tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tensorflow-cpu is ignored when installing tensorflow-addons
3 participants
@seanpmorgan @gabrieldemarmiesse @googlebot