Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring flake8 is compatible with black. #938

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Ensuring flake8 is compatible with black. #938

merged 1 commit into from
Jan 26, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Jan 26, 2020

See #932 for more context

Some modifications were added to ensure we don't get conflicts between black and flake8.

Actually pycodestyle have checks that are really nice to have even if we use black. It would be beneficial for us to keep them. e.g.:

  • do not compare types, use ‘isinstance()’
  • do not use variables named ‘l’, ‘O’, or ‘I’
  • do not use bare except, specify exception instead
    and so on...

For this reason, I followed black's documentation and only changed a few rules to ensure compatibility.

@gabrieldemarmiesse gabrieldemarmiesse requested a review from a team as a code owner January 26, 2020 14:49
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @gabrieldemarmiesse !

@seanpmorgan seanpmorgan merged commit b1bb485 into tensorflow:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants