doctest addons #677
doctest addons #677
Conversation
There was a problem hiding this comment.
@seanpmorgan Hi Sean, I wonder if we should also put the doctest on CI. My initial thought is not to do that. Maybe a neat description to ask contributors to so is enough. What do you think about it? Thank you!
@autoih Thanks for the contribution! Would you mind also making other code snippets compatible with doctest?
Hmmmm I think once we fully enforce this it could be a good idea to include in CI (depending on the runtime). But for the short-term I'm fine with this being a user ran test. |
@autoih Could you share the runtime for the whole repo? |
|
I modified a line to make sure the tests for dostrings were actually running in the CI. |
|
@autoih it seems the tests were not running. I changed a number and the CI is still passing. Could you make sure the tests are running correctly? You can ping me afterwards and I'll review. |
|
Thanks @gabrieldemarmiesse. For some reason, |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
* doctest for addons * minor sanity * add tfa & cleanup * doctest example * sanity check * files for doctest * remove tensor id * flake8 * use pytest * remove tfa_doctest * pytest for doctest * remove section in build * remove unsused files * update conftest; with no option named skip_custom_ops issue * flake8 * move np, tfa, tf to confest * concise command * fix docstr issue and add example * sanity check and missing doctest modules * reomve FloatTensorLike Co-authored-by: Tzu-Wei Sung <[email protected]>
This reverts commit 706e22f.
Address issue 582. Use DocTest to test the Python docstrings.
EDIT (@gabrieldemarmiesse) : fix #582