Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify default values explicitly #2812

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

faizan-m
Copy link
Member

@faizan-m faizan-m commented Feb 16, 2023

Description

Brief Description of the PR: explicitly specify default values to prevent breakage from upcoming tf.function changes

Fixes # (issue)

Type of change

Checklist:

  • [x ] I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • [x ] By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@boring-cyborg boring-cyborg bot added the image label Feb 16, 2023
@faizan-m faizan-m marked this pull request as ready for review February 16, 2023 21:28
@bhack
Copy link
Contributor

bhack commented Feb 16, 2023

@seanpmorgan Is the CI broken?

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 5876a83 into tensorflow:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants