Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against TF 2.9 #2696

Merged
merged 39 commits into from
May 20, 2022
Merged

Build against TF 2.9 #2696

merged 39 commits into from
May 20, 2022

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Apr 18, 2022 •
edited
Loading

Still needed:

  • TF2.9 tensorflow release
  • TF2.9 tensorflow-macos release

@boring-cyborg boring-cyborg bot added the github label Apr 18, 2022
@boring-cyborg boring-cyborg bot added the build label Apr 19, 2022
seanpmorgan
seanpmorgan commented Apr 25, 2022
View reviewed changes
WORKSPACE Outdated Show resolved Hide resolved
@bhack bhack mentioned this pull request May 19, 2022
Merged
4 tasks
bhack
bhack reviewed May 19, 2022
View reviewed changes
configure.py Show resolved Hide resolved
@bhack bhack requested a review from fsx950223 May 19, 2022 16:25
@seanpmorgan seanpmorgan changed the title [WIP] Build against TF 2.9 Build against TF 2.9 May 20, 2022
@seanpmorgan
Copy link
Member Author

@bhack @fsx950223 looks like changes to configure.py break custom op build compatibility. Maybe the last 3 commits or I saw another land in #2700 . I can take a look Sunday if it's not clear

@bhack
Copy link
Contributor

bhack commented May 20, 2022 •
edited
Loading

@bhack @fsx950223 looks like changes to configure.py break custom op build compatibility. Maybe the last 3 commits or I saw another land in #2700 . I can take a look Sunday if it's not clear

Are the Tensorflow <2.9 wheels rebuilt upstream on manylinux_2014? so have they D_GLIBCXX_USE_CXX11_ABI=1?

Cause if they are still the old ones released they are not using manylinux_2014...

@bhack
Copy link
Contributor

bhack commented May 20, 2022 •
edited
Loading

@seanpmorgan Yes confirmed we need to conditional build on the old container 2.7.2 and 2.8.1.

_ZN10tensorflow8internal21CheckOpMessageBuilder9NewStringB5cxx11Ev see the missing cxx11 symbol.

@bhack
Copy link
Contributor

bhack commented May 20, 2022 •
edited
Loading

Let see if ovverriding the CX11 abi flags it is enough for the old versions also if we build on manylinux2014.

@bhack
Copy link
Contributor

bhack commented May 20, 2022

I can take a look Sunday

Green lights here 🟢 🟢 🟢

It is better to take a sun-day 🌞 🏖️

@seanpmorgan seanpmorgan merged commit 1c3a2b2 into tensorflow:master May 20, 2022
@seanpmorgan
Copy link
Member Author

merging so our nightly is compatible with 2.9. Will have a full release by EOW

@seanpmorgan seanpmorgan deleted the build-tf29 branch May 20, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denadai2 denadai2 denadai2 left review comments

@bhack bhack bhack approved these changes

@fsx950223 fsx950223 Awaiting requested review from fsx950223

Assignees
No one assigned
Labels
build github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanpmorgan @bhack @denadai2 @fsx950223