fix compute_output_shape behavior in normalizations.py #2678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2677
Normalization layers in
normalizations.py
have been write very well. Thanks for the contributors. These layers work well in most cases, but their behavor incompute_output_shape
is very smallly different from their description and different fromtf.keras.layers.Layer
's design ideas aboutcompute_output_shape
.Since
tfa.layers.GroupNormalization
,tfa.layers.InstanceNormalization
andtfa.layers.FilterResponseNormalization
are all inherited fromtf.keras.layers.Layer
, they all overridecompute_output_shape
function.However, there is no need to override this function, because
tf.keras.layers.Layer
has done it well, i.e., ifcall
andbuild
functions have been overrided, the layer can automaticly give out correct output_shape buycompute_output_shape
in superclass. Remove the overridedcompute_output_shape
, the bug will disappear.Actually, overriding
compute_output_shape
when inherite a custom layer from tf.keras.layer.Layer is usually unnecessary in most cases, unless a user wants an output_shape that different fromcall
's output. But innormalizations.py
, normalization ops do not change shapes, the special above case is not suitable.Type of change
Checklist: