-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Assertion Ops for interpolate_bilinear #2609
Conversation
a44f3eb
to
bc5bdbf
Compare
Many SIG members have no visibility to the internal CL |
bc5bdbf
to
fc81e28
Compare
Hi bhack! Sorry about that! I have added more details! |
I understand this but do we have this documented somewhere? |
I am confused regarding what documentation would be ideal here? To put another way, there is currently a bug in the code. If you have a generalized function: |
Ok, we have some failing test.
|
8e68a1d
to
85a302d
Compare
Yeah those probably come from: #138 I think tf.function is stochastically parallelizing the asserts (which it shouldn't) leading to the flakiness. I fixed them by using explicit control dependencies but it appears that the code compliance check is not happy with that. Even if the assert bug is fixed at head, the flakiness will persist for previous TF versions. So I think for the sake of code functionality, we should consider adding this file to the exceptions list. |
3361a9c
to
3337eb0
Compare
Description
Enables the assertions to be included as part of the traced graph allowing functions traced with shapeless Tensors to be used for shaped instances and throw the proper exceptions.
Removed
test_symbolic_tensor_shape
because it is not supported as per KerasTensor update.This CL prevents the updated code from being broken on the rollout of enabling subtyping for tf.function.
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*