Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong type hinting of crf_log_likelihood #2471

Merged
merged 1 commit into from
May 5, 2021

Conversation

jeongukjae
Copy link
Contributor

Description

Brief Description of the PR: Fix wrong type hinting of crf_log_likelihood. crf_log_likelihood is returning a tuple of two tensors, but type hinting is a tf.Tensor now.

Fixes #2470

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@boring-cyborg boring-cyborg bot added the text label May 5, 2021
@google-cla google-cla bot added the cla: yes label May 5, 2021
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bhack bhack merged commit 3ebfd08 into tensorflow:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfa.text.crf.crf_log_likelihood function has a type error
2 participants