Enable doctest #2069
Merged
Enable doctest #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
commented
Aug 4, 2020
| @@ -1,2 +1,3 @@ | |||
| [pytest] | |||
| addopts = -ra | |||
| doctest_optionflags = ELLIPSIS NORMALIZE_WHITESPACE IGNORE_EXCEPTION_DETAIL DONT_ACCEPT_BLANKLINE | |||
There was a problem hiding this comment.
| @@ -20,7 +20,8 @@ RUN python configure.py | |||
| RUN pip install -e ./ | |||
| RUN --mount=type=cache,id=cache_bazel,target=/root/.cache/bazel \ | |||
| bash tools/install_so_files.sh | |||
| RUN pytest -v -n auto --durations=25 --cov=tensorflow_addons ./tensorflow_addons/ | |||
| RUN pytest -v -n auto --durations=25 --doctest-modules ./tensorflow_addons \ | |||
| --cov=tensorflow_addons ./tensorflow_addons/ | |||
There was a problem hiding this comment.
I think it makes sense to also run doctest in cpu_tests as docstring is also a part of codes.
|
Tests pass successfully on my local 😃
|
seanpmorgan
approved these changes
Aug 7, 2020
| @@ -20,7 +20,8 @@ RUN python configure.py | |||
| RUN pip install -e ./ | |||
| RUN --mount=type=cache,id=cache_bazel,target=/root/.cache/bazel \ | |||
| bash tools/install_so_files.sh | |||
| RUN pytest -v -n auto --durations=25 --cov=tensorflow_addons ./tensorflow_addons/ | |||
| RUN pytest -v -n auto --durations=25 --doctest-modules ./tensorflow_addons \ | |||
| --cov=tensorflow_addons ./tensorflow_addons/ | |||
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Enable doctest * Fix GeometricMean docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement of #667. Should be merged after #2068.
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*