Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop data_format argument #1980

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Drop data_format argument #1980

merged 2 commits into from
Jul 9, 2020

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jul 9, 2020

Closes #1825. Should we have some warning on deprecated arguments?

@boring-cyborg boring-cyborg bot added the image label Jul 9, 2020
@WindQAQ WindQAQ requested a review from a team July 9, 2020 05:08
@bot-of-gabrieldemarmiesse
Copy link

@fsx950223

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@AakashKumarNain
Copy link
Member

LGTM! Thanks

@AakashKumarNain AakashKumarNain merged commit 0dd08a9 into tensorflow:master Jul 9, 2020
@facaiy
Copy link
Member

facaiy commented Jul 12, 2020

Should we have some warning on deprecated arguments?

I think it's a good idea to warn user that the argument is not valid any more. And we can safely remove those warnings after 2~3 releases :-)

@WindQAQ
Copy link
Member Author

WindQAQ commented Jul 12, 2020

Should we have some warning on deprecated arguments?

I think it's a good idea to warn user that the argument is not valid any more. And we can safely remove those warnings after 2~3 releases :-)

Sounds good to me. Should we revert the change and add the warning?

@facaiy
Copy link
Member

facaiy commented Jul 12, 2020

Great, it's not necessary to revert the change, let's just add the warning :-)

@facaiy
Copy link
Member

facaiy commented Jul 12, 2020 •
edited
Loading

which package to add warninig, Tzu-wei ? eg: deprecation, etc

@WindQAQ
Copy link
Member Author

WindQAQ commented Jul 12, 2020

which package to add warninig, Tzu-wei ? eg: deprecation, etc

This looks like what we deal with deprecation.

@facaiy
Copy link
Member

facaiy commented Jul 12, 2020

Thanks, I'm fine with it

@WindQAQ WindQAQ mentioned this pull request Jul 12, 2020
Merged
WindQAQ added a commit that referenced this pull request Jul 12, 2020
@WindQAQ
Revert "Drop data_format argument (#1980)"
bd0f5a2 
This reverts commit 0dd08a9.
@WindQAQ WindQAQ mentioned this pull request Jul 12, 2020
Merged
ashutosh1919 pushed a commit to ashutosh1919/addons that referenced this pull request Jul 12, 2020
@WindQAQ @ashutosh1919
Drop data_format argument (tensorflow#1980)
467c029 
* Drop data_format arg

* Drop data_format args
WindQAQ added a commit that referenced this pull request Jul 12, 2020
@WindQAQ
Revert "Drop data_format argument (#1980)" (#1991)
9082557 
This reverts commit 0dd08a9.
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@WindQAQ
Drop data_format argument (tensorflow#1980)
1ac0659 
* Drop data_format arg

* Drop data_format args
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@WindQAQ
Revert "Drop data_format argument (tensorflow#1980)" (tensorflow#1991)
982a936 
This reverts commit 0dd08a9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AakashKumarNain AakashKumarNain AakashKumarNain approved these changes

Assignees
No one assigned
Labels
cla: yes image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent APIs within tfa.image and between tf.image and tfa.image
5 participants
@WindQAQ @bot-of-gabrieldemarmiesse @AakashKumarNain @facaiy @googlebot