Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RAdam optional float total steps #1871

Merged
merged 1 commit into from
May 23, 2020
Merged

Remove RAdam optional float total steps #1871

merged 1 commit into from
May 23, 2020

Conversation

seanpmorgan
Copy link
Member

Closes #1380

@bot-of-gabrieldemarmiesse
Copy link

@CyberZHG

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@WindQAQ WindQAQ self-requested a review May 23, 2020 05:50
WindQAQ
WindQAQ approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WindQAQ WindQAQ merged commit 86127cf into tensorflow:master May 23, 2020
@seanpmorgan seanpmorgan deleted the remove-optional-float-totalsteps branch May 24, 2020 13:09
ashutosh1919 pushed a commit to ashutosh1919/addons that referenced this pull request Jul 12, 2020
@seanpmorgan @ashutosh1919
* Remove optional float total steps (tensorflow#1871)
d02770b
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@seanpmorgan
* Remove optional float total steps (tensorflow#1871)
ddf253d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

Assignees
No one assigned
Labels
cla: yes optimizers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the possibility to use a float as total_steps in rectified Adam
4 participants
@seanpmorgan @bot-of-gabrieldemarmiesse @WindQAQ @googlebot