Add Echo State Network (ESN) layer #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
reviewed
May 28, 2020
There was a problem hiding this comment.
Hi @pedrolarben Sorry for the late reply. I have some comments here. Please check it out.
cc @qlzh727
tensorflow_addons/layers/esn.py
Outdated
| H. Jaeger | ||
| "The "echo state" approach to analysing and training recurrent neural networks". | ||
| GMD Report148, German National Research Center for Information Technology, 2001. | ||
| https://www.researchgate.net/publication/215385037 |
There was a problem hiding this comment.
Could we use the hyperlink here? Like xxx.
There was a problem hiding this comment.
@WindQAQ Thanks for your review :)
Do you mean something like this?
Option A:
This is based on the paper
H. Jaeger
["The "echo state" approach to analysing and training recurrent neural networks".
GMD Report148, German National Research Center for Information Technology, 2001.]
(https://www.researchgate.net/publication/215385037)
Option B:
This is based on the [paper](https://www.researchgate.net/publication/215385037)
H. Jaeger
"The "echo state" approach to analysing and training recurrent neural networks".
GMD Report148, German National Research Center for Information Technology, 2001.
Option C:
This is based on the paper
H. Jaeger
["The "echo state" approach to analysing and training recurrent neural networks"]
(https://www.researchgate.net/publication/215385037).
GMD Report148, German National Research Center for Information Technology, 2001.
I think I prefer option C, please let me know your opinion
There was a problem hiding this comment.
@pedrolarben I prefer C too :-)
WindQAQ
approved these changes
May 30, 2020
ashutosh1919
pushed a commit
to ashutosh1919/addons
that referenced
this pull request
Jul 12, 2020
* Added Echo State Network (ESN) layer * removed super arguments * removed constant argument from esn call * Changed test name esn layer * Added hyperlink to esn docs
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added Echo State Network (ESN) layer * removed super arguments * removed constant argument from esn call * Changed test name esn layer * Added hyperlink to esn docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1809.
After adding the ESN recurrent cell #1811, here it is the ESN layer.