Added the DepreciationWarning for the custom op version of activations functions #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
requested review from
AakashKumarNain and
WindQAQ
as code owners
gabrieldemarmiesse
added
the
backport r0.9
|
@fsx950223 @AakashKumarNain @digantamisra98 You are owners of some files modified in this pull request. |
|
Can we have few words in the string so that we advice the user/dev that is a global change for all the activations? |
|
Sure, why not. |
Squadrick
approved these changes
May 10, 2020
|
Thanks for the review! |
ashutosh1919
pushed a commit
to ashutosh1919/addons
that referenced
this pull request
Jul 12, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of #1775