Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport r0.8] Fix LAMB optimizer regex parsing #1555

Merged

Conversation

bot-of-gabrieldemarmiesse

Backport ce16e62 from #1532

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 8c2d84f into tensorflow:r0.8 Apr 3, 2020
@jarednielsen
Copy link
Contributor

Thanks! Is there an ETA for publishing 0.8.5 to PyPi?

@seanpmorgan
Copy link
Member

seanpmorgan commented Apr 3, 2020

Thanks! Is there an ETA for publishing 0.8.5 to PyPi?

We're running into VM disk space limits on the GitHub action. Currently discussing the best way forward. May require a 0.9 release with new features + bugfixes

Will update an ETA shortly

@jarednielsen
Copy link
Contributor

Good to know. In the meantime, would using the latest tfa-nightly package work?

@seanpmorgan
Copy link
Member

Good to know. In the meantime, would using the latest tfa-nightly package work?

Yes it should. Will update here with an ETA for 0.9 release after our monthly meeting today

@seanpmorgan
Copy link
Member

@jarednielsen 0.9 has been published.

@jarednielsen
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants