-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colab Notebook for Normalizations #144
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/144 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
Thanks @Smokrow Looks great. @seanpmorgan @facaiy should the ipynb files be in examples folder ? Because /docs folder would be overwritten everytime we run API docs generator. |
Good point. I will move it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Smokrow this looks great and thanks for starting our push for examples. Comments noted above
@Smokrow when time allows:
|
We mark this PR as WIP until tf core adds a normalization layer. After that I will change the links in the notebook since the comparison is not working right now |
@Smokrow Just FYI this should be unblocked now that we are built against tf2-beta |
@seanpmorgan Sry for the long wait |
This comment has been minimized.
This comment has been minimized.
Minor updates
minor edit
Rm warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks Moritz!
First draft of a Colab Notebook for Normalization layers.
I tried to formulate the description very basic and non technical for non ML experts while also including some more advanced topics like initialisers for example.
I will probably add a Recurrent example for one of the layers (Maybe layer normalization) as well.