Added code coverage to tools/run_cpu_tests.sh #1299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the
No module named _sqllite3
that we had before was an issue of python not being compiled with sqllite support. So nothing we can do about it in the custom-ops image.Something we can do though is running it in the standard python3.5 docker image since the python used here supports it. So now, if we want to look at the code coverage in the master branch, we just need to look at the logs of the minimal cpu build.
Also the progress plain is used to have the full output when building the image locally. By default buildkit swallow the output. I tried and it also worked when
DOCKER_BUILDKIT=0
so my hope is that this option won't break the script for people who don't have a version of docker recent enough.See #1243 (comment)
and https://stackoverflow.com/questions/1210664/no-module-named-sqlite3