Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code coverage to tools/run_cpu_tests.sh #1299

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Added code coverage to tools/run_cpu_tests.sh #1299

merged 1 commit into from
Mar 14, 2020

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Mar 13, 2020

So the No module named _sqllite3 that we had before was an issue of python not being compiled with sqllite support. So nothing we can do about it in the custom-ops image.

Something we can do though is running it in the standard python3.5 docker image since the python used here supports it. So now, if we want to look at the code coverage in the master branch, we just need to look at the logs of the minimal cpu build.

Also the progress plain is used to have the full output when building the image locally. By default buildkit swallow the output. I tried and it also worked when DOCKER_BUILDKIT=0 so my hope is that this option won't break the script for people who don't have a version of docker recent enough.

See #1243 (comment)
and https://stackoverflow.com/questions/1210664/no-module-named-sqlite3

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks very cool. 90% total coverage, but a few submodules are clearly lagging.

@seanpmorgan seanpmorgan merged commit bde78c3 into tensorflow:master Mar 14, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants