Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use pytest to run the tests #1207

Closed
wants to merge 36 commits into from
Closed

[WIP] Use pytest to run the tests #1207

wants to merge 36 commits into from

Conversation

gabrieldemarmiesse
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse commented Mar 2, 2020 •
edited
Loading

Do not merge/review. It's just a proof of concept.

@bot-of-gabrieldemarmiesse
Copy link

@RomainBrault @rahulunair @SSaishruthi @RaphaelMeudec @pkan2

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@gabrieldemarmiesse
Added a dockerfile test
5928bef 
Done.

Explicit copy.

Less spamming from the bot when notifying codeowners (#1183)

* Less spamming from the bot.

Remove all mentions of nosla. (#1184)

Removed erroneous scale_fn from CLR subclasses (#1160)

* Removed erroneous scale_fn from CLR subclasses
* Updated CLR docstrings

Make release_linux.sh configurable for python version (#1191)

* Produce one wheel at a time.

use default tfa (#1195)

Ignore so files.

22 Failed tests.

Excluded broken activation tests.

Skip hamming_test.py

Skip failing tests.

Skip some more tests.

Skip failing test.

Skipping bad test.

All tests are passing.

Added todo.

Added the pytest test.

Revert useless change.
@gabrieldemarmiesse
Merge branch 'master' into proof_of_concept_pytest
cdd014e
@gabrieldemarmiesse
Added durations to know running times.
8aab725
@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Mar 2, 2020
Closed
@gabrieldemarmiesse
Copy link
Member Author

gabrieldemarmiesse commented Mar 6, 2020 •
edited
Loading

This pull request needs
#1225
#1224
#1223
#1222
#1186
to be merged before.

Once they're all merged, I'll update this pull request with the idea from Jazon in the meeting and then we can merge it.

@gabrieldemarmiesse gabrieldemarmiesse added the blocked Pending something elses completion label Mar 6, 2020
@gabrieldemarmiesse gabrieldemarmiesse marked this pull request as ready for review March 6, 2020 22:33
@gabrieldemarmiesse gabrieldemarmiesse changed the title Proof of concept pytest Use pytest to run the tests Mar 6, 2020
@boring-cyborg boring-cyborg bot added the losses label Mar 7, 2020
@boring-cyborg boring-cyborg bot added the text label Mar 7, 2020
@boring-cyborg boring-cyborg bot added the seq2seq label Mar 7, 2020
@gabrieldemarmiesse
Copy link
Member Author

gabrieldemarmiesse commented Mar 7, 2020 •
edited
Loading

Made a clean version of this PR in #1243

@gabrieldemarmiesse gabrieldemarmiesse deleted the proof_of_concept_pytest branch March 8, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facaiy facaiy Awaiting requested review from facaiy

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

@guillaumekln guillaumekln Awaiting requested review from guillaumekln guillaumekln is a code owner

@qlzh727 qlzh727 Awaiting requested review from qlzh727 qlzh727 is a code owner

Assignees
No one assigned
Labels
build cla: yes github layers losses optimizers seq2seq test-cases Related to Addons tests text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @bot-of-gabrieldemarmiesse @googlebot