Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast dense_image_warp_test #1180

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fast dense_image_warp_test #1180

merged 1 commit into from
Feb 28, 2020

Conversation

autoih
Copy link
Member

@autoih autoih commented Feb 28, 2020 •
edited
Loading

Reduce few cases in shapes_to_try and have 40.9s -> 19.6s
related to 1143

@autoih autoih requested a review from WindQAQ as a code owner February 28, 2020 01:51
@boring-cyborg boring-cyborg bot added the image label Feb 28, 2020
@bot-of-gabrieldemarmiesse
Copy link

@WindQAQ

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@seanpmorgan
Copy link
Member

@WindQAQ

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@gabrieldemarmiesse Seems like the blacklist isn't working correctly?

seanpmorgan
seanpmorgan approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I don't see anything that is being validated by that extra shape

@seanpmorgan seanpmorgan merged commit 6987c99 into tensorflow:master Feb 28, 2020
@gabrieldemarmiesse
Copy link
Member

I just realized that tagging someone is case insensitive. It's a quick fix.

@autoih autoih deleted the dense branch March 27, 2020 23:49
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@autoih
speed up dense_image_warp (tensorflow#1180)
aa5af57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees
No one assigned
Labels
cla: yes image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@autoih @bot-of-gabrieldemarmiesse @seanpmorgan @gabrieldemarmiesse @googlebot