Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codeowners #1176

Merged
merged 7 commits into from
Feb 27, 2020
Merged

Update codeowners #1176

merged 7 commits into from
Feb 27, 2020

Conversation

seanpmorgan
Copy link
Member

Closes #1168

@gabrieldemarmiesse
Copy link
Member

@seanpmorgan could we merge the bot before? It will then check your CODEOWNERS and report if it is valid (typos can happen)

qlzh727
qlzh727 previously approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for consolidating this. LGTM.

@seanpmorgan seanpmorgan changed the title Update codeowners [WIP] Update codeowners Feb 27, 2020
@seanpmorgan seanpmorgan changed the title [WIP] Update codeowners Update codeowners Feb 27, 2020
@gabrieldemarmiesse
Copy link
Member

I think my bot doesn't like tabs. It should handle multiple spaces without problem.

gabrieldemarmiesse
gabrieldemarmiesse approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

@gabrieldemarmiesse gabrieldemarmiesse merged commit 63e4d4c into tensorflow:master Feb 27, 2020
@seanpmorgan seanpmorgan deleted the update-codeowners branch April 8, 2020 23:17
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@seanpmorgan
Update codeowners (tensorflow#1176)
8458d55 
* Update codeowners

* Update documentation

* Lint

* Update links

* Fix error

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

@qlzh727 qlzh727 qlzh727 left review comments

@facaiy facaiy Awaiting requested review from facaiy

@guillaumekln guillaumekln Awaiting requested review from guillaumekln guillaumekln is a code owner

@shun-lin shun-lin Awaiting requested review from shun-lin

@Squadrick Squadrick Awaiting requested review from Squadrick

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees
No one assigned
Labels
activations callbacks cla: yes github image layers losses metrics optimizers seq2seq text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CODEOWNERS to match documentation
4 participants
@seanpmorgan @gabrieldemarmiesse @qlzh727 @googlebot