-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify proxy maintainers #1167
Notify proxy maintainers #1167
Conversation
@tensorflow/sig-addons-maintainers You are owners of some files modified in this pull request. |
Hooray! |
I suppose we need to remove all people who have write access, right? They already get a notification. and also tensorflow/sig-addons-maintainers since it doesn't seem to trigger anything: #1137 (comment) |
Thanks this is fantastic!
Subsequent PR:
|
The easiest is to hard-code in the python file the people with write access. This is not public information so I cannot fetch it automatically. I'll add a filter somewhere. We want to minimize spamming. So the bot will only notify when the pull request is opened. Never after. It's also simpler code-wise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks again!
* Made the bot code. * Used a blacklist.
Fix #1145