Added the test cases for tf.distribute.MirroredStrategy() to the test_runner #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweill
reviewed
Jun 19, 2019
…t uses TF_CONFIG here
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
========================================
- Coverage 90.53% 90% -0.53%
========================================
Files 31 31
Lines 2726 2742 +16
Branches 434 438 +4
========================================
Hits 2468 2468
- Misses 179 195 +16
Partials 79 79
Continue to review full report at Codecov.
|
cweill
suggested changes
Jun 20, 2019
…t uses TF_CONFIG here and changes to keep it close to the source version.
|
Looks good to me. I'll merge it on our side. |
|
@cweill thanks :) |
cweill
pushed a commit
that referenced
this pull request
Jun 24, 2019
…_runner | Closes PR #115. Copybara import of the project: - 0df5fc6 Changed the protobuf version to 3.6.1 to accomodate lates... by chandramouli <[email protected]> - 64985e0 Merge branch 'master' into master by Charles Weill <[email protected]> - 3d8cd3a Merge pull request #1 from tensorflow/master by chandramoulirajagopalan <[email protected]> - b21ed49 Added tf.distribute.MirroredStrategy() test to estimator_... by chandramouli <[email protected]> - 7116db2 Using MultiWorkerMirroredStrategy instead of MirroredStra... by chandramouli <[email protected]> - b0c21af Using MultiWorkerMirroredStrategy instead of MirroredStra... by chandramouli <[email protected]> - 62b3050 Merge branch 'master' into master by chandramoulirajagopalan <[email protected]> - 8185883 Merge 62b3050 into cfb35... by chandramoulirajagopalan <[email protected]> PiperOrigin-RevId: 254859026
|
This is now merged in master, so I'm closing this PR. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.