This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Refactor Session to remove code duplication #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a lot of code duplication involved in just juggling and handing off various fields of `ValidatorConfig`. Instead of that, this makes a copy of the `ValidatorConfig` at the time a given client thread is started, and passes is it through wholesale, storing it in Session. Finally, `Connection` is made into a proper trait, allowing the generic parameter on `Session` to be removed, instead storing the session in `Box<dyn Connection>`. This massively simplifies the involved code.
tarcieri
force-pushed
the
session-and-connection-refactor
branch
from
f354446 to
9052e47
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code duplication involved in just juggling and handing off various fields of
ValidatorConfig.Instead of that, this makes a copy of the
ValidatorConfigat the time a given client thread is started, and passes is it through wholesale, storing it in Session.Finally,
Connectionis made into a proper trait, allowing the generic parameter onSessionto be removed, instead storing the session inBox<dyn Connection>.This massively simplifies the involved code.