-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockchain/v0: relax termination conditions and increase sync timeout #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5741 +/- ##
==========================================
- Coverage 60.48% 60.32% -0.17%
==========================================
Files 259 259
Lines 23334 23345 +11
==========================================
- Hits 14114 14083 -31
- Misses 7754 7783 +29
- Partials 1466 1479 +13
|
see blockchain/doc.go for the spec Refs #5718
melekes
requested review from
ebuchman,
erikgrinaker and
tessr
as code owners
December 7, 2020 08:52
melekes
changed the title
blockchain/vX: ensure we switch to consensus after timeout
blockchain/v0: relax termination conditions and increase sync timeout
Dec 7, 2020
erikgrinaker
reviewed
Dec 7, 2020
erikgrinaker
approved these changes
Dec 7, 2020
alexanderbez
reviewed
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5718