Skip to content

Commit

Permalink
Reduce p2p log noise (#7465)
Browse files Browse the repository at this point in the history
* reduce some logs

* reduce error logs

* remove debug
  • Loading branch information
tac0turtle authored Dec 17, 2021
1 parent 2cbb35f commit b14dc70
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 0 additions & 4 deletions consensus/reactor.go
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,6 @@ OUTER_LOOP:
for {
// Manage disconnects from self or peer.
if !peer.IsRunning() || !conR.IsRunning() {
logger.Info("Stopping gossipDataRoutine for peer")
return
}
rs := conR.conS.GetRoundState()
Expand Down Expand Up @@ -638,7 +637,6 @@ OUTER_LOOP:
for {
// Manage disconnects from self or peer.
if !peer.IsRunning() || !conR.IsRunning() {
logger.Info("Stopping gossipVotesRoutine for peer")
return
}
rs := conR.conS.GetRoundState()
Expand Down Expand Up @@ -763,13 +761,11 @@ func (conR *Reactor) gossipVotesForHeight(
// NOTE: `queryMaj23Routine` has a simple crude design since it only comes
// into play for liveness when there's a signature DDoS attack happening.
func (conR *Reactor) queryMaj23Routine(peer p2p.Peer, ps *PeerState) {
logger := conR.Logger.With("peer", peer)

OUTER_LOOP:
for {
// Manage disconnects from self or peer.
if !peer.IsRunning() || !conR.IsRunning() {
logger.Info("Stopping queryMaj23Routine for peer")
return
}

Expand Down
8 changes: 3 additions & 5 deletions p2p/pex/pex_reactor.go
Original file line number Diff line number Diff line change
Expand Up @@ -387,15 +387,14 @@ func (r *Reactor) ReceiveAddrs(addrs []*p2p.NetAddress, src Peer) error {
// If this address came from a seed node, try to connect to it without
// waiting (#2093)
if srcIsSeed {
r.Logger.Info("Will dial address, which came from seed", "addr", netAddr, "seed", srcAddr)
go func(addr *p2p.NetAddress) {
err := r.dialPeer(addr)
if err != nil {
switch err.(type) {
case errMaxAttemptsToDial, errTooEarlyToDial, p2p.ErrCurrentlyDialingOrExistingAddress:
r.Logger.Debug(err.Error(), "addr", addr)
default:
r.Logger.Error(err.Error(), "addr", addr)
r.Logger.Debug(err.Error(), "addr", addr)
}
}
}(netAddr)
Expand Down Expand Up @@ -491,7 +490,6 @@ func (r *Reactor) ensurePeers() {
// TODO: consider moving some checks from toDial into here
// so we don't even consider dialing peers that we want to wait
// before dialling again, or have dialed too many times already
r.Logger.Info("Will dial address", "addr", try)
toDial[try.ID] = try
}

Expand All @@ -504,7 +502,7 @@ func (r *Reactor) ensurePeers() {
case errMaxAttemptsToDial, errTooEarlyToDial:
r.Logger.Debug(err.Error(), "addr", addr)
default:
r.Logger.Error(err.Error(), "addr", addr)
r.Logger.Debug(err.Error(), "addr", addr)
}
}
}(addr)
Expand Down Expand Up @@ -717,7 +715,7 @@ func (r *Reactor) crawlPeers(addrs []*p2p.NetAddress) {
case errMaxAttemptsToDial, errTooEarlyToDial, p2p.ErrCurrentlyDialingOrExistingAddress:
r.Logger.Debug(err.Error(), "addr", addr)
default:
r.Logger.Error(err.Error(), "addr", addr)
r.Logger.Debug(err.Error(), "addr", addr)
}
continue
}
Expand Down

0 comments on commit b14dc70

Please sign in to comment.