-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still a draft. But looking good so far.
A couple of extra points:
- I think this could also be a good area to define the standard Tendermint RPC errors
- We don't fully comply with the JSON RPC2.0 spec right? Here might be a good place to outline where exactly we diverge
Agree here, should this be a separate PR?
Instead of trying to define what we support of JSON RPC 2.0 and what we don't. I would like to say the spec is JSON RPC 2.0 compliant and Tendermint-Go is not adhering to the spec. This will get the Tendermint team to become spec compliant at the RPC layer. This is still up for debate, but this aligns with the goal of getting the implementation to follow specs instead of veering from the spec in order to make things easier. |
Sure, up to you |
|
||
#### Parameters | ||
|
||
- `limit (integer)` The amount of txs to respond with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be paginated or something. In tendermint-go this has a upper bound of 100 i.e. you can only request the top 100 txs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, it would be good to paginate more things.
Co-authored-by: Callum Waters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things but otherwise good to go
Co-authored-by: Callum Waters <[email protected]>
Co-authored-by: Callum Waters <[email protected]>
Description
This PR decribes the RPC layer of tendermint. For now this takes what is present on the Go implementation and calls it the canonical implementation. After this is merged we will be able to reduce or expand the spec and anything outside the spec is an implementation detail.
closes #273
this spec does not contain:
Many of these routes are implementation specific and my not be shared across implementations.