feature: search attribute renaming #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a `temporalcloud_namespace_search_attribute` resource that can be used to create search attributes. Search attributes can't currently be deleted at an API level and this commit only implements `Create`. `Read`, `Update`, and `Delete` will come in another PR.
This commit implements the `Update` path for search attributes by renaming them via the `RenameCustomSearchAttribute` API.
Base automatically changed from
swgillespie/search-attribute-resource-2
to
main
February 22, 2024 04:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the
Updatepath for search attributes by renaming them via theRenameCustomSearchAttributeAPI.What was changed
Why?
Checklist
Closes
How was this tested: