Update Registry suggest CAN refactor #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
upd-suggest-can
branch
2 times, most recently
from
18d5251 to
299e672
Compare
stephanos
changed the title
stephanos
force-pushed
the
upd-suggest-can
branch
from
299e672 to
99ab3aa
Compare
stephanos
commented
Feb 4, 2025
|
|
||
| func (r *registry) SuggestContinueAsNew() bool { | ||
| // TODO: implement me | ||
| return false |
There was a problem hiding this comment.
Implementation to follow ...
stephanos
force-pushed
the
upd-suggest-can
branch
2 times, most recently
from
c08c378 to
9aadb5a
Compare
stephanos
commented
Feb 4, 2025
| @@ -136,6 +136,7 @@ func NewWorkflowWithSignal( | |||
| startRequest.StartRequest.Identity, | |||
| nil, | |||
| nil, | |||
| nil, | |||
There was a problem hiding this comment.
New Workflow, there's no Update registry ...
stephanos
force-pushed
the
upd-suggest-can
branch
3 times, most recently
from
84f1fa4 to
9eb4485
Compare
stephanos
force-pushed
the
upd-suggest-can
branch
from
9eb4485 to
bd42af7
Compare
alexshtin
approved these changes
Feb 5, 2025
|
Not tooooo bad :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactoring to allow Update registry to allow suggesting CAN.
Why?
Preparation for implementation. "Make the change easy, then make the easy change".
How did you test it?
Potential risks
Documentation
Is hotfix candidate?