Do not send backfill task when event is empty #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai719
approved these changes
Jan 22, 2025
xwduan
added a commit
that referenced
this pull request
Jan 22, 2025
<!-- Describe what has changed in this PR --> Do not send backfill task when event is empty <!-- Tell your future self why have you made these changes --> Backfill tasks should always have associated events. If there is no event(i.e. for a state only transition), then no backfill to perform and we should skip the task <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> n/a <!-- Assuming the worst case, what can be broken when deploying this change to production? --> n/a <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> n/a <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Do not send backfill task when event is empty
Why?
Backfill tasks should always have associated events. If there is no event(i.e. for a state only transition), then no backfill to perform and we should skip the task
How did you test it?
n/a
Potential risks
n/a
Documentation
n/a
Is hotfix candidate?
no