Refactoring: rename UpdateActivityWithCallback method on mutable state to UpdateActivity #6832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychebotarev
force-pushed
the
y_refactor
branch
from
18bdf12 to
67c2527
Compare
alexshtin
changed the title
alexshtin
approved these changes
Nov 16, 2024
ychebotarev
force-pushed
the
y_refactor
branch
from
ed6e84a to
71821cc
Compare
yycptt
approved these changes
Nov 18, 2024
| @@ -389,12 +389,13 @@ func (r *TaskRefresherImpl) refreshTasksForActivity( | |||
| } | |||
|
|
|||
| if CompareVersionedTransition(minVersionedTransition, EmptyVersionedTransition) == 0 { // Full refresh | |||
| // clear activity timer task mask for later activity timer task re-generation | |||
| activityInfo.TimerTaskStatus = TimerTaskStatusNone | |||
|
|
|||
| // need to update activity timer task mask for which task is generated | |||
| if err := mutableState.UpdateActivity( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Old UpdateActivity was not actually working. ActivityInfo in pending activities is a pointer, so calculating size was wrong. Few other reasons.
How did you test it?
unit tests
Risks
With this change the size of mutable state is calculated properly. This means that in some cases it may change, thus becoming larger then before, and trigger some errors.
Documentation
Is hotfix candidate?
No